Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make modifying root stack async #9080

Merged
merged 2 commits into from Nov 25, 2021

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Nov 25, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner November 25, 2021 02:54
@ammarkarachi
Copy link
Contributor Author

@sachscode still the fastest approver past the rockies

@sundersc sundersc merged commit 5859e93 into aws-amplify:master Nov 25, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 26, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.5.3 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants