Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make modifying root stack async #9080

Merged
merged 2 commits into from
Nov 25, 2021
Merged

feat: make modifying root stack async #9080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2e535
feat: make modifying root stack async
Nov 25, 2021
33ae575
fix: console log removed
Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/amplify-provider-awscloudformation/src/resource-package/resource-export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,20 +251,22 @@ export class ResourceExport extends ResourcePackager {
deleteParameters: boolean,
) {
const parameters = this.extractParametersFromTemplateNestedStack(cfnTemplate);
const template = this.modifyRootStack(cfnTemplate, deleteParameters);
const template = await this.modifyRootStack(cfnTemplate, deleteParameters);
await writeCFNTemplate(template, destinationPath, { templateFormat });
return parameters;
}

private async copyResource(sourcePath: string, destinationPath: string) {
let dir = destinationPath;
if(!fs.existsSync(sourcePath)){
return;
}
// if there is an extension then get the dir path
// extension points to the fact that it's a file
if (path.extname(destinationPath)) {
dir = path.dirname(destinationPath);
}
await fs.ensureDir(dir);

await fs.copy(sourcePath, destinationPath, { overwrite: true, preserveTimestamps: true, recursive: true });
}

Expand Down