Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow api updates without migration #9864

Merged
merged 4 commits into from Mar 8, 2022

Conversation

edwardfoyle
Copy link
Member

Description of changes

When extensibility was implemented, api updates were blocked unless the resource was migrated. This change allows updates to the resource without requiring an update

Issue #, if available

fixes #9675

Description of how you validated changes

manually verified and added a migration e2e test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner February 26, 2022 00:09
@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2022

This pull request introduces 1 alert when merging 46d52d9 into b22b67d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

…tion/cfn-api-artifact-handler.ts

Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2022

This pull request introduces 1 alert when merging 5778213 into b22b67d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 9a8873a into b22b67d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@edwardfoyle edwardfoyle merged commit 389f551 into aws-amplify:master Mar 8, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 14, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.24 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to update existing GraphQL API (v1) resource without migrating
3 participants