Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): spinner hiding prompt #9875

Merged
merged 2 commits into from Mar 9, 2022

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Feb 28, 2022

Description of changes

The spinner interfered with the prompt in Lambda Layers when exporting it, this change creates a singleton by exporting it in the core

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner February 28, 2022 20:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #9875 (439dfc5) into master (2bd4172) will increase coverage by 0.36%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9875      +/-   ##
==========================================
+ Coverage   53.00%   53.37%   +0.36%     
==========================================
  Files         830      833       +3     
  Lines       46012    46089      +77     
  Branches     9826     9849      +23     
==========================================
+ Hits        24390    24601     +211     
+ Misses      19604    19484     -120     
+ Partials     2018     2004      -14     
Impacted Files Coverage Δ
...rmation/cdk-stack-builder/apigw-stack-transform.ts 11.76% <0.00%> (ø)
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (ø)
...-graphql-auth-transformer/src/utils/definitions.ts 100.00% <ø> (ø)
...amplify-graphql-index-transformer/src/resolvers.ts 99.59% <ø> (ø)
...chable-transformer/src/cdk/create-cfnParameters.ts 100.00% <ø> (ø)
...earchable-transformer/src/generate-resolver-vtl.ts 90.47% <ø> (ø)
...y-provider-awscloudformation/src/push-resources.ts 17.30% <0.00%> (ø)
...udformation/src/utils/remove-dependent-function.ts 10.00% <0.00%> (+1.30%) ⬆️
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)
.../graphql-transformer-core/src/collectDirectives.ts 14.01% <16.66%> (+0.29%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22b67d...439dfc5. Read the comment docs.

@@ -31,6 +31,7 @@ export * from './category-interfaces';
export * from './customPoliciesUtils';
export * from './utils/doc-links';
export * from './utils/gql-transformer-version';
export * from './spinner';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make more sense if the spinner is apart of the amplify-prompts package instead of core. cc @edwardfoyle

@jhockett jhockett merged commit c7e7b90 into aws-amplify:master Mar 9, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 14, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.24 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants