New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): spinner hiding prompt #9875
Conversation
b849097
to
28c8df8
Compare
Codecov Report
@@ Coverage Diff @@
## master #9875 +/- ##
==========================================
+ Coverage 53.00% 53.37% +0.36%
==========================================
Files 830 833 +3
Lines 46012 46089 +77
Branches 9826 9849 +23
==========================================
+ Hits 24390 24601 +211
+ Misses 19604 19484 -120
+ Partials 2018 2004 -14
Continue to review full report at Codecov.
|
@@ -31,6 +31,7 @@ export * from './category-interfaces'; | |||
export * from './customPoliciesUtils'; | |||
export * from './utils/doc-links'; | |||
export * from './utils/gql-transformer-version'; | |||
export * from './spinner'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make more sense if the spinner is apart of the amplify-prompts
package instead of core. cc @edwardfoyle
👋 Hi, this pull request was referenced in the v7.6.24 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.24. |
Description of changes
The spinner interfered with the prompt in Lambda Layers when exporting it, this change creates a singleton by exporting it in the core
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.