Fixing issue #954 #1029
Fixing issue #954 #1029
Conversation
ghost
assigned 
| const userPoolId = userPoolIdSelector(finishedStack.Outputs); | ||
| const userPoolClientId = userPoolClientIdSelector(finishedStack.Outputs); | ||
|
|
||
| // const userPoolIdSelector = outputValueSelector(ResourceConstants.OUTPUTS.AuthCognitoUserPoolIdOutput) |
There was a problem hiding this comment.
Can we get rid of this instead of commenting?
|
Before merging this it would be nice to get this CLI integration tests for the api category wired up. I will work on this later this week. |
| expect(meta.Region).toBeDefined(); | ||
| const { AuthRoleName, UnauthRoleName, UnauthRoleArn, AuthRoleArn, DeploymentBucketName } = meta; | ||
|
|
||
| await expect(UnauthRoleName).toBeIAMRoleWithArn(UnauthRoleArn); |
There was a problem hiding this comment.
Removed these assertions.
| const { output } = getProjectMeta(projRoot).api.simplemodel; | ||
| const { GraphQLAPIIdOutput, GraphQLAPIEndpointOutput, GraphQLAPIKeyOutput } = output; | ||
|
|
||
| await expect(GraphQLAPIIdOutput).toBeDefined() |
There was a problem hiding this comment.
Can we assert that these values we have are indeed the right ones using aws-sdk
There was a problem hiding this comment.
Added a todo in the code for additional checking but I think pulling from the CloudFormation outputs should be enough for now.
mikeparisstuff
force-pushed
the
issue954
branch
from
0ebf5a1
to
76399a9
Compare
|
Thanks for the review @yuth. I am going to merge this. |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#954
Description of changes:
This stops creating API keys when user pools auth is enabled.
Changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.