fix: explicitly assign buffer to node.global #10308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After a discussion with @josefaidt , the Initial change which explicitly initialized global.buffer in
polyfills.ts
has been removed and thebuffer
library is now imported through a webpack.config plugin.Issue #, if available
10304
Description of how you validated changes
amplify mock does not correctly render GraphiQL explorer and Cognito fails OIDC token generation with the error
"Error: Error when generating OIDC token: Buffer is not defined".
The change explicitly defines global ( if missing on platforms ) and assigns buffer to global .
Test:
and Update graphql schema
GraphiQL UI works fine.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.