fix(graphql-key-transformer): prevent non-scalar key fields #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves aws-amplify#5300 Logic for 'isScalar' treated lists as scalar types. This allowed indexes to be created with invalid key types. This modifies the isScalar function to return false for list types, and updates other areas as needed with a new 'isScalarOrScalarList' function Includes new test which fails without this fix. Fixes adjacent tests failing because of missing model transforms, and not for the stated reason.
RossWilliams
force-pushed
the
fix/key-list-fields
branch
from
dcd68ef
to
71f6cfd
Compare
RossWilliams
force-pushed
the
fix/key-list-fields
branch
from
71f6cfd
to
45e68ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #5319 +/- ##
==========================================
+ Coverage 57.76% 57.77% +0.01%
==========================================
Files 406 406
Lines 18630 18640 +10
Branches 3721 3725 +4
==========================================
+ Hits 10761 10769 +8
- Misses 7187 7189 +2
Partials 682 682
Continue to review full report at Codecov.
|
SwaySway
approved these changes
Oct 30, 2020
SwaySway
added a commit
that referenced
this pull request
Dec 14, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5300
Description of changes:
Logic for 'isScalar' function treated lists as scalar types. Lists are not scalar, and are not valid primary key types. This allowed indexes to be created with invalid key types, resulting in runtime errors.
This modifies the isScalar function to return false for list types, and updates other areas as needed with a new 'isScalarOrScalarList' function. Added explicit list checks where needed, type narrowing, and changes to satisfy compiler.
Includes new test which fails without this fix.
Fixes adjacent tests failing because of missing model transforms, and not for the stated reason.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.