Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing pinpoint policy #5918

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

nikhname
Copy link
Contributor

Issue #, if available:

Description of changes:
Change in pinpoint policy actions based on discussion

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikhname nikhname changed the title fix: removing getUserEndpoints fix: changing pinpoint policy Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #5918 (e326ebd) into master (6a5f957) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5918    +/-   ##
========================================
  Coverage   58.13%   58.13%            
========================================
  Files         413      413            
  Lines       18886    18886            
  Branches     3573     3771   +198     
========================================
  Hits        10980    10980            
+ Misses       7244     7224    -20     
- Partials      662      682    +20     
Impacted Files Coverage Δ
.../amplify-category-notifications/lib/auth-helper.js 0.00% <ø> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.90% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 25.09% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5f957...e326ebd. Read the comment docs.

@palpatim
Copy link
Member

@nikhname, @kaustavghosh06 -- This change has caused customer issues on the client side, because customers can no longer remove endpoints once they hit the 10 endpoint limit. What is the expectation for customers to be able to remove endpoints?

@kayuapi
Copy link

kayuapi commented Jan 11, 2021

+1, facing same issues as @palpatim

@bakalar
Copy link

bakalar commented Jan 19, 2021

Having the same issue. Why was getUserEndpoints removed?

@lawmicha
Copy link
Member

this appears to be a corresponding JS library change aws-amplify/amplify-js#7245
JS issue on client side after upgrading Amplify CLI aws-amplify/amplify-js#7251

@GeorgeBellTMH
Copy link

Can we please get this and the corresponding change in js reverted? This is causing all sorts of problems...

@GeorgeBellTMH
Copy link

@ammarkarachi and @nikhname can you please give us some reasoning why this was done and what is being done to resolve this?

@GeorgeBellTMH
Copy link

Are we just going to leave this broken?

@thenderson55
Copy link

This is a serious issue that is causing a lot of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants