Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-nodejs-function-runtime-provider): fix lambda error format #6350

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Jan 9, 2021

Issue #, if available:
fix #5553
Description of changes:
return proper error message and stack if a string error is provided return string error as is

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner January 9, 2021 00:55
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #6350 (69f1559) into master (8486632) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6350    +/-   ##
========================================
  Coverage   57.20%   57.21%            
========================================
  Files         473      474     +1     
  Lines       21595    21599     +4     
  Branches     4075     4292   +217     
========================================
+ Hits        12354    12358     +4     
+ Misses       8381     8361    -20     
- Partials      860      880    +20     
Impacted Files Coverage Δ
...ejs-function-runtime-provider/src/utils/execute.ts 71.92% <0.00%> (ø)
...dejs-function-runtime-provider/src/utils/invoke.ts 87.87% <100.00%> (-0.36%) ⬇️
...function-runtime-provider/src/utils/invokeUtils.ts 100.00% <100.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.44% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8486632...69f1559. Read the comment docs.

Copy link
Member

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo and one clarification question

return proper error message and stack if a string error is provided return string error as is

fix aws-amplify#5553
@edwardfoyle edwardfoyle merged commit 0cf5282 into aws-amplify:master Jan 14, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Best way to develop code to run for Lambda's, current setup is painfully slow and manual
2 participants