Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply empty arrays as default values but not undefined values #6445

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

edwardfoyle
Copy link
Member

Issue #, if available:
#5681

fixes an issue that caused some tests to fail in PR #6071 which were reverted in #6179

Description of changes:
Use _.assignWith with a customizer to not assign undefined values instead of using _.merge which would not overwrite empty arrays

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner January 20, 2021 22:56
@edwardfoyle edwardfoyle requested review from attilah and SwaySway and removed request for a team January 20, 2021 22:57
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #6445 (00ac44d) into master (4ce4138) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6445      +/-   ##
==========================================
+ Coverage   57.30%   57.34%   +0.03%     
==========================================
  Files         474      474              
  Lines       21669    21671       +2     
  Branches     4090     4091       +1     
==========================================
+ Hits        12418    12427       +9     
+ Misses       8390     8383       -7     
  Partials      861      861              
Impacted Files Coverage Δ
.../awscloudformation/utils/auth-defaults-appliers.ts 89.65% <100.00%> (+26.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce4138...00ac44d. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants