docs: add readme to vtl resolvers directory #6718
Conversation
There was a problem hiding this comment.
Hi @rajrajhans thanks for the contribution! I think it would be better to add the README as a separate file in the resources directory of amplify-category-api and then copy the file into the project destination rather than defining the readme as a string. The file could go under a path like amplify-category-api/resources/awscloudformation/resolver-readme/README.md.
Also, it looks like a lint check is failing, so double check that.
cc @renebrandel to comment on the wording of the README
|
Wording looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #6718 +/- ##
=======================================
Coverage 56.80% 56.80%
=======================================
Files 486 486
Lines 22030 22030
Branches 4400 4400
=======================================
Hits 12515 12515
Misses 8638 8638
Partials 877 877 Continue to review full report at Codecov.
|
|
@edwardfoyle Thank you for the review. I have made the required changes, and fixed the lint issues as well. |
packages/amplify-category-api/src/provider-utils/awscloudformation/cfn-api-artifact-handler.ts
Outdated
Show resolved
Hide resolved
…n instead of string literals in fs.copyFileSync
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: Closes #6325
Description of changes:
Adds a README to
amplify/backend/api/<MyApp>/resolversdirectory describing the override process for resolvers. More details in the linked issue.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.