New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BatchGetItem to appsync-simulator(#5963) #7952
feat: add BatchGetItem to appsync-simulator(#5963) #7952
Conversation
packages/amplify-appsync-simulator/src/__tests__/data-loader/dynamo-db/utils/index.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add E2E tests.
@@ -12,5 +12,8 @@ | |||
"declaration": true, | |||
"typeRoots": ["../../node_modules/@types", "node_modules/@types", "./typings"] | |||
}, | |||
"references": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an unrelated change. Can you remove it.
Is there a place where I should put them? I'm trying to figure out where the e2e tests for the other operations have been placed. For now, I'm working on adding to |
Hey, any progress on it? |
Hi, same question, because i changed my offline appsync plugin to use this because its "active & maintened" but face this problem too. To bypass the problem, i have builded the package amplify-appsync-simulator with your code, used Then, i can use it in the serverless-appsync-simulator as dependancies (in a fork too) Finally, i use this fork in my serverless project ! Thank you very much @behrmans & others :) |
1e95c27
to
62bf704
Compare
Reason for force-push was branch was so far behind and had trouble rebasing. All seems fine now. I still plan on trying to finish this PR hopefully soon |
Codecov Report
@@ Coverage Diff @@
## master #7952 +/- ##
==========================================
+ Coverage 47.29% 47.31% +0.01%
==========================================
Files 665 665
Lines 32931 32942 +11
Branches 6641 6645 +4
==========================================
+ Hits 15576 15587 +11
Misses 15682 15682
Partials 1673 1673
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@behrmans can we move this to draft since its still a work in progress? Or are you ready for review? |
62bf704
Any news about this PR / draft ? |
@behrmans are you still working on this? |
Closing due to inactivity. |
Description of changes
amplify-e2e-core
inamplify-migration-tests
package due to errors regardingamplify-e2e-core
not being found.Issue #, if available
Issue 5963
Copied almost all code from PR 5965
Reason I made new PR was because it seemed like a lot of time had passed (9 months) since the original PR had made progress on the failing test. Please let me know if I should have handled this differently and I will correct any issues ASAP
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.