New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amplify-category-auth): add auth verification mechanisms to front end config #8037
Merged
jhockett
merged 1 commit into
aws-amplify:master
from
lazpavel:auth-zero-config-verification-mechanisms
Sep 10, 2021
Merged
feat(amplify-category-auth): add auth verification mechanisms to front end config #8037
jhockett
merged 1 commit into
aws-amplify:master
from
lazpavel:auth-zero-config-verification-mechanisms
Sep 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazpavel
force-pushed
the
auth-zero-config-verification-mechanisms
branch
from
August 26, 2021 01:35
05bcf19
to
2164dc9
Compare
lazpavel
force-pushed
the
auth-zero-config-verification-mechanisms
branch
from
August 26, 2021 14:08
2164dc9
to
728bba6
Compare
attilah
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the suggested simplification before merge, but LGTM!
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Show resolved
Hide resolved
jhockett
pushed a commit
that referenced
this pull request
Sep 10, 2021
jhockett
added a commit
to jhockett/amplify-cli
that referenced
this pull request
Sep 10, 2021
… to frontend config (aws-amplify#8037) (aws-amplify#8093)" This reverts commit b8949b2.
2 tasks
jhockett
added a commit
that referenced
this pull request
Sep 10, 2021
👋 Hi, this pull request was referenced in the v5.6.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.6.0. |
github-actions
bot
added
the
referenced-in-release
Issues referenced in a published release changelog
label
Sep 14, 2021
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
… to frontend config (aws-amplify#8037) (aws-amplify#8093)" (aws-amplify#8158) This reverts commit b8949b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Description of how you validated changes
yarn test
passesChecklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.