Lambda auth minor fixes #8741
Lambda auth minor fixes #8741
Conversation
| context.print.success('Available advanced settings:'); | ||
| advancedSettingsList.forEach(setting => context.print.info('- '.concat(setting))); | ||
| context.print.info(''); | ||
| if(!templateParameters.skipAdvancedSection) { |
There was a problem hiding this comment.
nit: can we reverse this condition and early return to avoid more nesting?
There was a problem hiding this comment.
Updated as suggested. Also, updated the skipNextSteps method to follow the same code style.
| print.info( | ||
| '"amplify publish" builds all of your local backend and front-end resources (if you added hosting category) and provisions them in the cloud', | ||
| ); | ||
| print.success(`Successfully added resource ${completeParams.resourceName} locally.`); |
There was a problem hiding this comment.
nit: would be nice to switch to amplify-prompts for these print statements
There was a problem hiding this comment.
I've few more fast follow tasks related to this module, I will include this.
Codecov Report
@@ Coverage Diff @@
## master #8741 +/- ##
==========================================
- Coverage 56.88% 56.88% -0.01%
==========================================
Files 756 756
Lines 42247 42252 +5
Branches 8650 8656 +6
==========================================
Hits 24033 24033
- Misses 17393 17397 +4
- Partials 821 822 +1
Continue to review full report at Codecov.
|
This reverts commit 8ff558b.
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v6.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0. |
Description of changes
GraphQL Lambda Authorizerto the list of NodeJS templates.amplify add and update apiworkflow.Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.