fix: populating custom resource stack with account/region placeholders #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcvberg
added
the
first-time-contributor
2 tasks
|
Thanks @marcvberg. Could you help with the failing |
|
Looks like it got merged and reverted. Shouldn't it be merged again or what is the process? |
|
Hi @mpashkovskiy, the PR was reverted because the change was breaking adding the custom resource e2e test. The original issue was reopen as it needs more investigation. |
|
👋 Hi, this pull request was referenced in the v7.6.12 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.12. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Custom stacks build with CDK now populated with environment containing account and region placeholders
Issue #, if available
refs #9360
Description of how you validated changes
Using tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.