Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build resource when adding new env #9847

Merged
merged 3 commits into from Mar 10, 2022
Merged

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Feb 24, 2022

Description of changes

  • Build resource first when adding a new env locally when project is git pulled
  • Add missing await

Issue #9508, if available

Description of how you validated changes

  • Manually tested
  • e2e test for same scenario

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from a team as a code owner February 24, 2022 16:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #9847 (0ac8f73) into master (fcf9100) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9847   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files         830      830           
  Lines       45991    45990    -1     
  Branches     9820     9819    -1     
=======================================
  Hits        24423    24423           
  Misses      19556    19556           
+ Partials     2012     2011    -1     
Impacted Files Coverage Δ
packages/amplify-category-auth/src/index.js 15.97% <0.00%> (+0.05%) ⬆️
...y-provider-awscloudformation/src/initialize-env.ts 22.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf9100...0ac8f73. Read the comment docs.

@jhockett jhockett merged commit 7264e27 into aws-amplify:master Mar 10, 2022
danielleadams added a commit that referenced this pull request Mar 10, 2022
danielleadams added a commit that referenced this pull request Mar 10, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 14, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.24 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants