Skip to content

Commit

Permalink
fix: fixing typescript version to 4.4.x, since 4.5.2 breaks the imports
Browse files Browse the repository at this point in the history
  • Loading branch information
alharris-at committed Nov 18, 2021
1 parent 9d3c881 commit b726682
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 9 deletions.
4 changes: 2 additions & 2 deletions packages/codegen-ui-react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/codegen-ui-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@types/temp": "^0.9.1",
"prettier": "2.3.2",
"temp": "^0.9.4",
"typescript": "^4.2.4"
"typescript": "~4.4.4"
},
"peerDependencies": {
"react": "^17.0.2",
Expand Down
8 changes: 7 additions & 1 deletion packages/codegen-ui/lib/errors/error-transformer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,13 @@ export const transformCodegenError = (error: any | unknown): InternalError | Inv
return error;
}

return new InternalError('Unhandled internal error occurred - see stack trace.');
let errorMsg = 'Unhandled Codegen Error Occurred';

if (error.stack) {
errorMsg += ` - ${JSON.stringify(error.stack)}`;
}

return new InternalError(errorMsg);
};

export const handleCodegenErrors = (target: Object, propertyKey: string, descriptor: PropertyDescriptor) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/codegen-ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 24 additions & 3 deletions packages/test-generator/lib/generators/GenerateTestApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
*/
import { ModuleKind, ScriptTarget, ScriptKind } from '@aws-amplify/codegen-ui-react/dist/lib/react-render-config';
import { NodeTestGenerator } from './NodeTestGenerator';

const DISABLED_SCHEMAS = [
Expand All @@ -24,12 +25,32 @@ const DISABLED_SCHEMAS = [
'CardWithInvalidChildComponentType', // Expected failure cases
];

const generator = new NodeTestGenerator({
const INTEG_TEST_PATH = 'packages/integration-test/src/ui-components';

const tsxGenerator = new NodeTestGenerator({
writeToLogger: false,
writeToDisk: true,
renderConfigOverride: {}, // Use Defaults
outputConfigOverride: {
outputPathDir: 'packages/integration-test/src/ui-components',
outputPathDir: INTEG_TEST_PATH,
},
});

generator.generate(generator.getTestCases(DISABLED_SCHEMAS));
const jsxGenerator = new NodeTestGenerator({
writeToLogger: false,
writeToDisk: true,
renderConfigOverride: {
module: ModuleKind.ESNext,
target: ScriptTarget.ESNext,
script: ScriptKind.JSX,
renderTypeDeclarations: true,
},
outputConfigOverride: {
outputPathDir: INTEG_TEST_PATH,
},
});

const testCases = tsxGenerator.getTestCases(DISABLED_SCHEMAS);

// tsxGenerator.generate(testCases);
jsxGenerator.generate(testCases);
2 changes: 1 addition & 1 deletion packages/test-generator/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b726682

Please sign in to comment.