Skip to content

Commit

Permalink
feat: throw error on invalid script kind (#133)
Browse files Browse the repository at this point in the history
  • Loading branch information
dpilch committed Oct 14, 2021
1 parent 3737db2 commit ee3e79f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { ScriptKind } from 'typescript';
import { scriptKindToFileExtension } from '../react-render-config';

describe('ReactRenderConfig', () => {
describe('scriptKindToFileExtension', () => {
test('JS', () => {
expect(scriptKindToFileExtension(ScriptKind.JS)).toEqual('js');
});

test('JSX', () => {
expect(scriptKindToFileExtension(ScriptKind.JSX)).toEqual('jsx');
});

test('TSX', () => {
expect(scriptKindToFileExtension(ScriptKind.TSX)).toEqual('tsx');
});

test('TS (not supported)', () => {
expect(() => scriptKindToFileExtension(ScriptKind.TS)).toThrow(new Error('Invalid script kind: TS'));
});
});
});
4 changes: 1 addition & 3 deletions packages/studio-ui-codegen-react/lib/react-render-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@ export type ReactRenderConfig = FrameworkRenderConfig & {

export function scriptKindToFileExtension(scriptKind: ScriptKind): string {
switch (scriptKind) {
case ScriptKind.TS:
return 'ts';
case ScriptKind.TSX:
return 'tsx';
case ScriptKind.JS:
return 'js';
case ScriptKind.JSX:
return 'jsx';
default:
return 'tsx';
throw new Error(`Invalid script kind: ${ScriptKind[scriptKind]}`);
}
}

0 comments on commit ee3e79f

Please sign in to comment.