Collections rendering invalid items variable

[cwoolum]

When rendering a collection, for some reason, it's trying to bind an items vairable without actually mapping it from props.

function ListingCardCollection(props) {
  var _a = props;
  return (
    <Collection
      type="list"
      isPaginated="true"
      items={items}
      {...props}
      {...getOverrideProps(props.overrides, "Collection")}
    >
      {function (item, index) {
        return (
          <ListingCard
            {...findChildOverrides(props.overrides, "ListingCard")}
          ></ListingCard>
        );
      }}
    </Collection>
  );
}

{"name":"ListingCardCollection","children":[{"children":[],"name":"ListingCard","componentType":"ListingCard","properties":{},"overrides":{},"variants":[]}],"id":"c-7m9oAaC8SO0M40Pnvu","bindingProperties":{},"componentType":"Collection","properties":{"type":{"value":"list"},"isPaginated":{"value":"true"}},"overrides":{},"variants":[]}

[dpilch]

Is the expected behavior that there should be no items prop?

function ListingCardCollection(props) {
  var _a = props;
  return (
    <Collection
      type="list"
      isPaginated="true"
      {...props}
      {...getOverrideProps(props.overrides, "Collection")}
    >
      {function (item, index) {
        return (
          <ListingCard
            {...findChildOverrides(props.overrides, "ListingCard")}
          ></ListingCard>
        );
      }}
    </Collection>
  );
}

[cwoolum]

The items can be passed in but they need to be destructured from the props

[frimfram]

"items" is supposed to be a variable resulting from useDataStore hook.
Please see the golden file here: https://tiny.amazon.com/166zmdlhq

const { buttonUser } = useDataStoreBinding({
  type: "collection",  // returns zero or one or many records
  model: User,
  criteria: filterCriteria
 });

  <Collection type="list" items={ buttonUser } gap="1.5rem" backgroundColor={backgroundColor}>
  
  {(item, index) => (
  <Flex key={index} {...props} {...getOverrideProps(overrides, 'Flex')}>
 <Button

[frimfram]

@cwoolum I thought we said that there would be no hard coded "items" (data for collection), so why would it come from properties?

[cwoolum]

What I meant was that codegen will never hardcode an array of data. items can be passed in by a user though.