fix(amplify_authenticator): trims strings for password confirmation diffs #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
approved these changes
May 31, 2022
dnys1
reviewed
May 31, 2022
| @@ -112,7 +112,7 @@ FormFieldValidator<String> validatePasswordConfirmation( | |||
| context, | |||
| InputResolverKey.passwordConfirmationEmpty, | |||
| ); | |||
| } else if (getPassword() != passwordConfirmation) { | |||
| } else if (getPassword().trim() != passwordConfirmation.trim()) { | |||
There was a problem hiding this comment.
Can we trim them when we save them in authenticator_state.dart in case this issue comes up elsewhere?
There was a problem hiding this comment.
@dnys1 That'll work for the password and newPassword fields (so I've made that chage), but I believe the actual password confirmation should be trimmed here since the FormField validator is using the content from the field and not from state.
dnys1
approved these changes
May 31, 2022
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jun 13, 2022
dnys1
pushed a commit
that referenced
this pull request
Jun 14, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jun 15, 2022
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jun 20, 2022
dnys1
pushed a commit
that referenced
this pull request
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR potentially fixed #1592, but we will need additional feedback from the customer to confirm. The change is valid regardless of whether it fixes this particular issue.
Description of changes:
Trims strings in password confirmation comparison.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.