Android unit tests analytics #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 59681ba.
fjnoyp
requested review from
skywardpixel,
haverchuck,
Ashish-Nanda and
Amplifiyer
haverchuck
reviewed
Aug 10, 2020
| print(e); | ||
| } | ||
|
|
||
| await amplifyInstance.configure(amplifyconfig); |
There was a problem hiding this comment.
Not a huge deal since this is just the example app, but you'll want to catch an error here.
haverchuck
approved these changes
Aug 10, 2020
|
I'm going to delete this PR and put it into a separate PR based directly off of master. |
|
Closing the PR. We will use offline tests and a different testing framework solution. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Android Unit Tests for the Analytics Pinpoint Module.
This PR is meant to demonstrate how to setup and run unit tests in Android for your modules. Please make sure to follow as closely as possible to the setup used here. Kyle Y and I ran into very significant bugs and issues with alternate setups and different code. Feel free to contact us if you run into issues when developing your own unit tests.
Please focus on the changes to AmplifyAnalyticsPinpointPluginTest
Changes made to the base android plugins module can be ignored (they are already contained in a separate PR 'Amplify analytics' that will be merged