Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sigv4): Makes chunking opt-in #1820

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Jun 26, 2022

This was made the default since it's much more efficient, especially on web for large uploads, but some S3 operations do not support it so it should not be the default. Instead, it will be selectively enabled in the SDK layer for operations which allow it.

Also cleans up example.

Dillon Nys added 2 commits June 26, 2022 14:06
This was made the default since it's much more efficient, especially on web for large uploads, but some S3 operations do not support it so it should not be the default. Instead, it will be selectively enabled in the SDK layer for operations which allow it.

commit-id:0c690d3f
Remove local type annotations since these are not used throughout the rest of the codebase and we should not establish a precedence we don't follow ourselves. The original intention was to make things more clear but it can set a bad example.

commit-id:4c0d01a1
@dnys1 dnys1 requested a review from a team as a code owner June 26, 2022 21:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #1820 (a4f9ccf) into main (6a5fdfc) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
+ Coverage   42.14%   42.47%   +0.32%     
==========================================
  Files         371      376       +5     
  Lines       10768    10873     +105     
==========================================
+ Hits         4538     4618      +80     
- Misses       6230     6255      +25     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 31.45% <ø> (ø)
ios-unit-tests 88.92% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ios/unit_tests/amplify_flutter_exampleTests.swift 94.59% <0.00%> (ø)
..._pinpoint_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...y_flutter_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...e/ios/unit_tests/MockAnalyticsCategoryPlugin.swift 15.38% <0.00%> (ø)
...ios/example/ios/unit_tests/AtomicResultTests.swift 87.75% <0.00%> (ø)

@dnys1 dnys1 merged commit a1f4056 into aws-amplify:main Jun 27, 2022
@dnys1 dnys1 deleted the fix/sigv4/chunking branch June 27, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants