Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): add sub and identities as standard attributes #1825

Merged

Conversation

Jordan-Nelson
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add sub and identities attributes

This is a subset of the changes that went into next in #1768 and #1804. I did not include the rest of the changes since the changes to the parse constructor is breaking.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner June 27, 2022 16:49
@Jordan-Nelson Jordan-Nelson enabled auto-merge (squash) June 27, 2022 16:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #1825 (05b673d) into main (6a5fdfc) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   42.14%   42.48%   +0.34%     
==========================================
  Files         371      375       +4     
  Lines       10768    10870     +102     
==========================================
+ Hits         4538     4618      +80     
- Misses       6230     6252      +22     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 31.45% <ø> (ø)
ios-unit-tests 89.04% <ø> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pes/auth/attribute/cognito_user_attribute_key.dart 50.00% <ø> (ø)
...e/ios/unit_tests/MockAnalyticsCategoryPlugin.swift 15.38% <0.00%> (ø)
...y_flutter_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
.../ios/unit_tests/amplify_flutter_exampleTests.swift 94.59% <0.00%> (ø)
...ios/example/ios/unit_tests/AtomicResultTests.swift 87.75% <0.00%> (ø)

@Jordan-Nelson Jordan-Nelson merged commit 76390c1 into aws-amplify:main Jun 28, 2022
Jordan-Nelson added a commit to Jordan-Nelson/amplify-flutter that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants