Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix various integ test issues #1838

Merged

Conversation

Jordan-Nelson
Copy link
Contributor

@Jordan-Nelson Jordan-Nelson commented Jun 30, 2022

Issue #, if available:

Description of changes:

  • skip test failing because adminCreateUser is not creating users with. a name attr
  • fix test that was failing because of a UserAlreadyExistsExceptions
  • update phone number generator to work with backends that have password reqs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner June 30, 2022 01:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1838 (27b22da) into main (07d8567) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         376      376           
  Lines       10876    10876           
=======================================
  Hits         4618     4618           
  Misses       6258     6258           
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 31.44% <ø> (ø)
ios-unit-tests 88.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Jordan-Nelson Jordan-Nelson merged commit 65d7e71 into aws-amplify:main Jul 6, 2022
@Jordan-Nelson Jordan-Nelson deleted the chore/fix-auth-integ-tests branch July 6, 2022 17:25
haverchuck pushed a commit that referenced this pull request Jul 13, 2022
Jordan-Nelson added a commit to Jordan-Nelson/amplify-flutter that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants