fix(storage): throw pluginNotAddedException when storage plugin not c… #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
approved these changes
Jul 20, 2022
dnys1
approved these changes
Jul 20, 2022
haverchuck
pushed a commit
that referenced
this pull request
Jul 21, 2022
haverchuck
pushed a commit
that referenced
this pull request
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1875
This PR improves error handling for storage category when plugin has not been added. Other categories have this check in core to ensure there is a plugin configured before calling a method on the plugin. Storage didn't have it, which gives an inconsistent error message in that scenario. This PR adds the same logic to storage.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.