Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Hosted UI server contention #2002

Merged
merged 1 commit into from Aug 8, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Aug 4, 2022

Fixes #2011

Fixes an issue where, on certain platforms, the open server connection is not closed before trying to force close the server.

@dnys1 dnys1 requested a review from a team as a code owner August 4, 2022 17:18
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #2002 (07944c0) into next (160c451) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #2002      +/-   ##
==========================================
- Coverage   43.41%   43.40%   -0.02%     
==========================================
  Files         118      116       -2     
  Lines        7447     7440       -7     
==========================================
- Hits         3233     3229       -4     
+ Misses       4214     4211       -3     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 26.64% <ø> (ø)
ios-unit-tests 89.59% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._pinpoint_ios/example/ios/Runner/AppDelegate.swift
..._auth_cognito/example/ios/Runner/AppDelegate.swift

@dnys1 dnys1 force-pushed the fix/hosted-ui/contention branch 3 times, most recently from 4e7553e to 77e63ef Compare August 4, 2022 23:06
Fixes an issue where, on certain platforms, the open server connection is not closed before trying to force close the server.

commit-id:4638b101
@dnys1 dnys1 merged commit c231f5b into aws-amplify:next Aug 8, 2022
@dnys1 dnys1 deleted the fix/hosted-ui/contention branch August 8, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants