fix(auth): Multi-auth DataStore bindings #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes multi-auth in DataStore when using Dart Auth. This requires implementing `getCurrentUser` on the native bridge. Since it's a synchronous method, we use a push-based approach to update a local cache on native to avoid blocking the main native thread which will cause deadlock. commit-id:15cbc60b
Codecov Report
@@ Coverage Diff @@
## next #2012 +/- ##
=======================================
Coverage 43.92% 43.92%
=======================================
Files 122 122
Lines 7549 7549
=======================================
Hits 3316 3316
Misses 4233 4233
Flags with carried forward coverage won't be shown. Click here to find out more. |
haverchuck
approved these changes
Aug 8, 2022
Jordan-Nelson
approved these changes
Aug 9, 2022
| await updateCurrentUser(null); | ||
| } | ||
| Amplify.Hub.listen(HubChannel.Auth, (AuthHubEvent event) { | ||
| updateCurrentUser(event.payload); |
There was a problem hiding this comment.
Is there any risk of race condition between the Native plugin trying to access the current user and this trying to update it?
There was a problem hiding this comment.
Yes but the retry mechanisms in DS should make up for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multi-auth in DataStore when using Dart Auth. This requires implementing
getCurrentUseron the native bridge. Since it's a synchronous method, we use a push-based approach to update a local cache on native to avoid blocking the main native thread which will cause deadlock.