Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authenticator): remove unnecessary assertion in PendingVerificationCheckState constructor #2324

Merged
merged 1 commit into from Nov 8, 2022

Conversation

Jordan-Nelson
Copy link
Contributor

Issue #, if available: #2311

Description of changes:

  • Remove an unnecessary assertion in PendingVerificationCheckState. This assertion checked that current step was signIn or confirmSignUp. There is no reason to have this assertion, and it was problematic after a password reset.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner November 7, 2022 20:38
@Jordan-Nelson Jordan-Nelson enabled auto-merge (squash) November 8, 2022 14:44
@Jordan-Nelson Jordan-Nelson merged commit f9f9cdd into main Nov 8, 2022
@Jordan-Nelson Jordan-Nelson deleted the fix/authenticator-assertion-error branch November 8, 2022 14:54
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Nov 9, 2022
…onCheckState constructor (aws-amplify#2324)

fix: remove assertion in constructor
dnys1 pushed a commit to dnys1/amplify-flutter that referenced this pull request Nov 9, 2022
## Release Notes
- chore: Bump iOS dependency ([aws-amplify#2334](aws-amplify#2334))
- fix(authenticator): remove unnecessary assertion in PendingVerificationCheckState constructor ([aws-amplify#2324](aws-amplify#2324))
- fix(authenticator): Username form validation Cognito requirements ([aws-amplify#2296](aws-amplify#2296))

## Cherry Picks
- 2bec0b8
- 5224c7f
- bb80302
- 7be5f9c
- e0a9c5b
- 4898720
- 32d689a
@dnys1 dnys1 mentioned this pull request Nov 9, 2022
dnys1 pushed a commit that referenced this pull request Nov 9, 2022
…onCheckState constructor (#2324)

fix: remove assertion in constructor
dnys1 pushed a commit that referenced this pull request Nov 9, 2022
## Release Notes
- chore: Bump iOS dependency ([#2334](#2334))
- fix(authenticator): remove unnecessary assertion in PendingVerificationCheckState constructor ([#2324](#2324))
- fix(authenticator): Username form validation Cognito requirements ([#2296](#2296))

## Cherry Picks
- 2bec0b8
- 5224c7f
- bb80302
- 7be5f9c
- e0a9c5b
- 4898720
- 32d689a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants