fix(api): fix subscription race condition from previous connection close #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
approved these changes
Nov 22, 2022
dnys1
reviewed
Nov 22, 2022
Comment on lines
455
to
463
|
|
||
| // No-op if already connected. | ||
| // Run after generating the connection message to account for connection | ||
| // closed while generating message. | ||
| await init(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // No-op if already connected. | |
| // Run after generating the connection message to account for connection | |
| // closed while generating message. | |
| await init(); | |
| if (_channel == null) { | |
| return _sendSubscriptionRegistrationMessage(request); | |
| } |
There was a problem hiding this comment.
Pushed a change w this suggestion (but kept await init()).
dnys1
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in API GraphQL subscriptions that is causing auth integ tests to fail. The issue arises when establishing a subscription on a connection that is in the process of being closed, causing an error from trying to send over a closed socket. This PR fixes it by moving some async logic so that the check of connection open/closed while establishing a subscription happens later and will open a new connection.
This fix is a little hacky and would usually have some more unit tests. I didn't do that here because 1) all this will be replaced by subscription state machine 2) the auth integ tests are already serving a sort of check here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.