Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): Dev-preview release #2605

Merged

Conversation

Jordan-Nelson
Copy link
Contributor

@Jordan-Nelson Jordan-Nelson commented Jan 27, 2023

Breaking Changes

  • fix(auth)!: Fetch Auth Session offline behavior (#2585)

Fixes

  • fix(api): do not include null values in ModelMutations.create (#2504)
  • fix(api): model helpers use targetNames in schemas with CPK enabled (#2559)
  • fix(auth): Clear credentials before redirect on Web (#2603)
  • fix(auth): Refresh token in non-state machine calls (#2572)
  • fix(authenticator): ARB syntax (#2560)
  • fix(aws_common): AWSFile contentType getter should not throw exception
  • fix(datastore): prevent unhandled exception crashing App rebuilding sync expression
  • fix(storage): incorrect transferred bytes emitted from upload task

Features

  • feat(analytics): Legacy data migration of Pinpoint Endpoint ID (#2489)
  • feat(smithy_aws): add copyWidht to S3ClientConfig
  • feat(storage): allow configuring transfer acceleration

Updated-Components: Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner January 27, 2023 18:47
Copy link
Contributor

@dnys1 dnys1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- feat(aft): Version bump command ([#2068](https://github.com/aws-amplify/amplify-flutter/pull/2068))

### Breaking Changes
- fix(auth)!: Fetch Auth Session offline behavior ([#2585](https://github.com/aws-amplify/amplify-flutter/pull/2585))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where isolating commits can be powerful. If the changes to aws_common were made in a separate commit, the version would not have needed a major bump.

No worries at all since the version of the package doesn’t matter right now. Just a good thing to keep in mind in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is though, this should be removed from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realized that after seeing this. To make sure we are on the same page, I will keep the version bump, but update the change log to not include this. Let me know if you think I should undo the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just the change log entry

## 0.4.0

### Features
- feat(aft): Version bump command ([#2068](https://github.com/aws-amplify/amplify-flutter/pull/2068))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See I made the same mistake here!

## 0.4.1

### Features
- feat(smithy_aws): add copyWidht to S3ClientConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

## 0.4.0+1

### Features
- feat(smithy_aws): add copyWidht to S3ClientConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

- fix(api): model helpers use targetNames in schemas with CPK enabled ([#2559](https://github.com/aws-amplify/amplify-flutter/pull/2559))

### Breaking Changes
- fix(auth)!: Fetch Auth Session offline behavior ([#2585](https://github.com/aws-amplify/amplify-flutter/pull/2585))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this

@@ -1,6 +1,6 @@
name: amplify_api_dart
description: The Amplify API category plugin in Dart-only, supporting GraphQL and REST operations.
version: 0.1.0
version: 0.1.0+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we haven't released this package yet so I don't believe a bump is needed in this package, but no harm having it I suppose.

## 1.0.0-next.4

### Fixes
- fix(api): model helpers use targetNames in schemas with CPK enabled ([#2559](https://github.com/aws-amplify/amplify-flutter/pull/2559))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Not related to datastore? Dk if this was from script or manually added. Some test files might have been touched by the diff on this change. no harm I suppose

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #2605 (a27e2ec) into next (cf9520c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             next    #2605   +/-   ##
=======================================
  Coverage   50.90%   50.90%           
=======================================
  Files          86       86           
  Lines        5813     5813           
=======================================
  Hits         2959     2959           
  Misses       2854     2854           
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 38.30% <ø> (ø)
ios-unit-tests 95.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dnys1 dnys1 changed the title chore: bump version chore(version): Dev-preview release Jan 30, 2023
Comment on lines +3 to +8
### Fixes
- fix(storage): incorrect transferred bytes emitted from upload task

### Features
- feat(storage): allow configuring transfer acceleration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these two items list in the CHNAGELOG of amplify_flutter package as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't currently supported in aft, so we'll need to come up with a mechanism for it

Dillon Nys and others added 3 commits January 30, 2023 11:58
Adds `amplify_api_dart` to the mix and creates components for DB Common, Secure Storage, and AWS Common
For the version commit message changelog, only include publishable packages. Also updates base ref logic to ensure packages can be moved in and out of components.
- fix(auth)!: Fetch Auth Session offline behavior ([aws-amplify#2585](aws-amplify#2585))

- fix(api): do not include null values in ModelMutations.create ([aws-amplify#2504](aws-amplify#2504))
- fix(api): model helpers use targetNames in schemas with CPK enabled ([aws-amplify#2559](aws-amplify#2559))
- fix(auth): Clear credentials before redirect on Web ([aws-amplify#2603](aws-amplify#2603))
- fix(auth): Refresh token in non-state machine calls ([aws-amplify#2572](aws-amplify#2572))
- fix(authenticator): ARB syntax ([aws-amplify#2560](aws-amplify#2560))
- fix(aws_common): AWSFile contentType getter should not throw exception
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression
- fix(storage): incorrect transferred bytes emitted from upload task

- feat(analytics): Legacy data migration of Pinpoint Endpoint ID ([aws-amplify#2489](aws-amplify#2489))
- feat(smithy_aws): add copyWith to S3ClientConfig
- feat(storage): allow configuring transfer acceleration

Updated-Components: Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Jordan-Nelson Jordan-Nelson merged commit 20d2215 into aws-amplify:next Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants