feat(core): add granular model read operations #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2611 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 360 360
Lines 10928 10928
=======================================
Hits 4995 4995
Misses 5933 5933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HuiSF
reviewed
Feb 2, 2023
| READ, | ||
| GET, | ||
| LIST, | ||
| SYNC, |
There was a problem hiding this comment.
Per my understanding these finer read operation controls work out of box for API plugin, are these finer controls supported in DataStore? If not, do we have a documentation calling this out - not to use these finer read control with DataStore?
There was a problem hiding this comment.
These are not supported in Datastore especially for the local storage. The auth rules are only respected when it syncs with cloud. Adding these enums is to make the modelgen file compiled for those who uses these files only for API usage.
There is no document on this part but I will have a PR out later to call out that the finer read ops are not recommended for Datastore usage. If cx insists on using them, the sync and listen are required.
There was a problem hiding this comment.
Update with the doc PR: aws-amplify/docs#5084
AaronZyLee
force-pushed
the
granular-read
branch
from
5e690bc
to
aa399d2
Compare
HuiSF
previously approved these changes
Feb 3, 2023
AaronZyLee
force-pushed
the
granular-read
branch
from
aa399d2
to
9b7f4b9
Compare
HuiSF
previously approved these changes
Feb 8, 2023
HuiSF
approved these changes
May 3, 2023
HuiSF
changed the title
HuiSF
changed the title
ragingsquirrel3
approved these changes
May 3, 2023
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 9, 2023
## 1.1.0 ### Features - Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) ### Fixes - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update SDK constraint to `^3.0.0-417.4.beta`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 10, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
May 11, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([#2611](#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([#3013](#3013)) - fix(repo): AGP 8.0 compatibility ([#2942](#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Stivenmore
pushed a commit
to JunoLuK/amplify-flutter
that referenced
this pull request
Jun 9, 2023
Stivenmore
pushed a commit
to JunoLuK/amplify-flutter
that referenced
this pull request
Jun 9, 2023
- Dart 3 support (must update Dart SDK constraint to `^3.0.0`) - feat(core): add granular model read operations ([aws-amplify#2611](aws-amplify#2611)) - fix(notifications): configure call hangs on Flutter app hot restart ([aws-amplify#3013](aws-amplify#3013)) - fix(repo): AGP 8.0 compatibility ([aws-amplify#2942](aws-amplify#2942)) - fix: convert AuthUserAttributeKey in updateUserAttributes Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix #2526
The purpose of adding enum in library is to ensure the model files generated by modelgen will be compiled. However, this is not intended for Datastore usage but for those who use modelgen files along with API plugin. It is not recommended to use them in the datastore due to the prerequisite of
syncandlisten. This is documented in the callout.Description of changes:
Add granular read operation enums in model auth operation rule
Refer https://docs.amplify.aws/cli/graphql/authorization-rules/#how-it-works
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.