fix(auth): Cancel sign in #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
fix/auth/cancel-sign-in
branch
from
5a4e792
to
531d99b
Compare
Properly enqueues sign-in calls and cancels previous attempts when
dnys1
force-pushed
the
fix/auth/cancel-sign-in
branch
from
531d99b
to
108e4f3
Compare
To prevent `dart:io` from being imported in JS code.
NikaHsn
reviewed
Apr 12, 2023
| @@ -614,28 +604,22 @@ class AmplifyAuthCognitoDart extends AuthPluginInterface | |||
| signInStep: AuthSignInStep.done, | |||
| ), | |||
| ); | |||
There was a problem hiding this comment.
nit: maybe extract the switch-case to a function as it is used for signIn and confirmSignIn
| @@ -47,7 +47,7 @@ class SignInStateMachine extends AuthStateMachine<SignInEvent, SignInState> { | |||
| SignInState get initialState => const SignInState.notStarted(); | |||
|
|
|||
| /// Flow used to sign in. | |||
| late final AuthFlowType authFlowType; | |||
| @@ -59,7 +59,7 @@ class SignInStateMachine extends AuthStateMachine<SignInEvent, SignInState> { | |||
| }(); | |||
|
|
|||
| /// Parameters to the flow. | |||
| late final SignInParameters parameters; | |||
There was a problem hiding this comment.
The same state machine can be used for multiple sign ins.
Comment on lines
561
to
563
| await _stateMachine.acceptAndComplete<SignInNotStarted>( | ||
| const SignInEvent.cancelled(), | ||
| ); |
There was a problem hiding this comment.
SignInStateMachine.resolve() calls _assertSignedOut() and _reset() before running the SignInEvent.initiate. why do we need to cancel sign in flow if any, isn't it taken care by the SignInStateMachine?
There was a problem hiding this comment.
Hmm yes this was leftover from earlier iterations. Removed 👍
Jordan-Nelson
approved these changes
Apr 12, 2023
NikaHsn
approved these changes
Apr 12, 2023
dnys1
pushed a commit
that referenced
this pull request
Apr 12, 2023
### Features - Publish push notifications plugin ### Fixes - fix(auth): Cancel sign in ([#2840](#2840)) Updated-Components: amplify_flutter, amplify_flutter_ios, amplify_core, amplify_datastore, amplify_datastore_plugin_interface, amplify_analytics_pinpoint, amplify_analytics_pinpoint_dart, amplify_api, amplify_auth_cognito, amplify_auth_cognito_dart, aws_common, amplify_db_common, amplify_push_notifications, amplify_push_notifications_pinpoint, amplify_storage_s3, amplify_storage_s3_dart, Amplify UI, Secure Storage, Smithy, Worker Bee
dnys1
pushed a commit
that referenced
this pull request
Apr 12, 2023
### Features - Publish push notifications plugin ### Fixes - fix(auth): Cancel sign in ([#2840](#2840)) Updated-Components: amplify_flutter, amplify_flutter_ios, amplify_core, amplify_datastore, amplify_datastore_plugin_interface, amplify_analytics_pinpoint, amplify_analytics_pinpoint_dart, amplify_api, amplify_auth_cognito, amplify_auth_cognito_dart, aws_common, amplify_db_common, amplify_push_notifications, amplify_push_notifications_pinpoint, amplify_storage_s3, amplify_storage_s3_dart, Amplify UI, Secure Storage, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly enqueues sign-in calls and cancels previous attempts when signing in or confirming a sign in.