-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(version): Bump version #3632
Conversation
* chore(actions): Update README * chore(actions): Clean up * chore(actions): Bump Dart SDK * chore(actions): Migrate to extension types Inline classes have been removed in favor of extension types.
Solves iOS timeouts by: - Using macOS XL runners (to improve performance of initial download/install) - Caching downloaded runtimes using built-in cache
Dependabot doesn't check this directory, by default. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#enabling-dependabot-version-updates-for-actions
Expands E2E backends for all TOTP/SMS MFA combinations.
Fix casing when mapping SDK exceptions.
Adds TOTP MFA support to the `signIn` and `confirmSignIn` flows and adds two new methods to the Cognito plugin for fetching and updating the user's MFA preferences: `fetchMfaPreference` and `updateMfaPreference`.
Adds E2E tests for TOTP MFA and splits existing MFA tests by backend configuration: SMS, TOTP, and SMS/TOTP.
* refactor(aft): Remove `libgit2dart` dependency * chore(repo): Remove `libgit2dart` submodule * ci: Remove `libgit2dart` patches * chore(repo): Remove `libgit2` references from READMEs
…ublish` (#3568) There are bespoke, often confusing, rules to how inter-repo constraints must be handled such that `pub` allows packages to be published. See #2885, #2366, #2865. This introduces a checker into both `aft constraints` and `aft publish` which validates that package constraints are configured to allow publishing and updates them (or reports an error) if not.
Some packages in the repo (for example, the `actions` pkg) set a pre-release Dart SDK constraint so that preview features of Dart can be leveraged. This updates `aft` so that: 1) `bootstrap` skips packages which set this constraint if the current Dart SDK doesn't support it; and 2) Ignores preview constraints in the constraints checker, since these packages do not need to conform to the global setting.
ci: Fix AWS credentials Bumps the `configure-aws-credentials` action so that we no longer receive this error: ``` Assuming role with OIDC Error: Could not assume role with OIDC: SecretAccessKey contains special characters. ```
The call from Native -> Dart to retrieve Auth credentials is being performed on a background thread which results in the following warning message. ``` The 'dev.flutter.pigeon.NativeAuthPlugin.fetchAuthSession' channel sent a message from native to Flutter on a non-platform thread. Platform channel messages must be sent on the platform thread. Failure to do so may result in data loss or crashes, and must be fixed in the plugin or application code creating that channel. ```
* chore: bump amplify android to 2.12.0 * chore: update example build.gradle * chore: increase ds sync timeout to 10 minutes
Adds TOTP MFA feature to The Authenticator package.
1d36f38
to
8b4e885
Compare
- feat(authenticator): TOTP MFA ([#3609](https://github.com/aws-amplify/amplify-flutter/pull/3609)) | ||
|
||
### Fixes | ||
- fix(datastore): Use platform thread ([#3607](https://github.com/aws-amplify/amplify-flutter/pull/3607)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should other fixes be here too?
|
||
### Fixes | ||
- fix(analytics): AWSPinpointUserProfile Added null check for user attributes ([#3598](https://github.com/aws-amplify/amplify-flutter/pull/3598)) | ||
- fix(auth): SDK exception mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have analytics here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core+Flutter package aggregate all the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so there are missing some missing feat and fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should've been more clear. Core captures all the Dart-only changes, Flutter captures all the Dart+Flutter changes.
## 1.4.0 | ||
|
||
### Features | ||
- feat(authenticator): TOTP MFA ([#3609](https://github.com/aws-amplify/amplify-flutter/pull/3609)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have authenticator here?
## 1.4.0 | ||
|
||
### Features | ||
- feat(authenticator): TOTP MFA ([#3609](https://github.com/aws-amplify/amplify-flutter/pull/3609)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be here?
8b4e885
to
5922504
Compare
### Features - feat(auth): TOTP MFA - feat(authenticator): TOTP MFA ([#3609](#3609)) ### Fixes - fix(analytics): AWSPinpointUserProfile Added null check for user attributes ([#3598](#3598)) - fix(auth): SDK exception mapping - fix(authenticator): Social button debug Property Type ([#3608](#3608)) - fix(datastore): Use platform thread ([#3607](#3607)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
5922504
to
a9684be
Compare
|
||
### Fixes | ||
- fix(analytics): AWSPinpointUserProfile Added null check for user attributes ([#3598](https://github.com/aws-amplify/amplify-flutter/pull/3598)) | ||
- fix(auth): SDK exception mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so there are missing some missing feat and fix
|
||
### Features | ||
- feat(auth): TOTP MFA | ||
- feat(authenticator): TOTP MFA ([#3609](https://github.com/aws-amplify/amplify-flutter/pull/3609)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if feat(authenticator) should be here, the pr does not have any change in the auth package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did have a small change, but yeah I could have removed this.
@@ -8,8 +8,7 @@ environment: | |||
|
|||
dependencies: | |||
test: ^1.22.1 | |||
amplify_secure_storage_dart: | |||
path: ../amplify_secure_storage_dart | |||
amplify_secure_storage_dart: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an override to get it from local path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That is handled by aft link
. Hardcoded paths can cause issues when publishing due to pub's constraint solver. See: #3568
aws_common: any | ||
aws_signature_v4: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from this: #3568
aws_common: any | ||
aws_signature_v4: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
built_value: ">=8.6.0 <8.7.0" | ||
collection: ^1.15.0 | ||
fixnum: ^1.0.0 | ||
path: ^1.8.0 | ||
smithy: ">=0.4.0+1 <0.5.0" | ||
smithy: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Features
Fixes
Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee