chore(actions): bump min swift version to 5.9 and updated CI jobs #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
force-pushed
the
chore/bump-swift-5.9
branch
from
c22329b
to
3463248
Compare
Jordan-Nelson
approved these changes
May 28, 2024
| @@ -16,8 +16,8 @@ | |||
| "dart.onlyAnalyzeProjectsWithOpenFiles": true, | |||
| "files.insertFinalNewline": true, | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll": true, | |||
| "source.organizeImports": true | |||
| "source.fixAll": "explicit", | |||
There was a problem hiding this comment.
Not sure if this was intentional or not. I think it is fine to leave this though. It looks like VS code changed this prop from a boolean to an enum and your editor likely migrated it automatically
https://code.visualstudio.com/updates/v1_85#_code-actions-on-save-and-auto
There was a problem hiding this comment.
Yeah, I went to back it out and it looked like it got auto migrated so I left it.
|
nit: Can you please update the PR change description to include upgrading the Android compileSdk to version 34. |
NikaHsn
approved these changes
May 28, 2024
Equartey
added a commit
that referenced
this pull request
May 28, 2024
Equartey
added a commit
that referenced
this pull request
May 28, 2024
Equartey
added a commit
to Equartey/amplify-flutter
that referenced
this pull request
May 29, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
latesttag for iOS CI jobsmacOS-12runner, which raises the min iOS simulator version we can test on to 15.0. In the meantime, we need to be onmacOS-14to avoid breaking CI jobs when they finish their migrationBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.