Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): improve amplify configure api error message #5021

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix(core): improve amplify configure api error message #5021

merged 1 commit into from
Jun 13, 2024

Conversation

NikaHsn
Copy link
Contributor

@NikaHsn NikaHsn commented Jun 12, 2024 •
edited
Loading

Issue #, if available: #4922

Description of changes:

  • set checked property to true when using JsonSerializable so generated fromJson functions include extra validation checks and so returns more descriptive error message includeing the field name.
  • regenerate codes
  • update the configure api to add the underlyingException to the ConfigurationError

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner June 12, 2024 17:22
@NikaHsn NikaHsn merged commit 9cbfe72 into main Jun 13, 2024
155 checks passed
hahnandrew pushed a commit that referenced this pull request Jun 24, 2024
@NikaHsn @hahnandrew
fix(core): improve amplify configure api error message (#5021)
2de8c95
@NikaHsn NikaHsn mentioned this pull request Jun 25, 2024
Merged
Jordan-Nelson pushed a commit that referenced this pull request Jun 27, 2024
@NikaHsn @Jordan-Nelson
fix(core): improve amplify configure api error message (#5021)
942cabb
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version
06acde0 
### Fixes
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

### Features
- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Jordan-Nelson Jordan-Nelson mentioned this pull request Jun 27, 2024
Merged
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version
f8b43bc 
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version
f89ce8e 
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson pushed a commit that referenced this pull request Jun 27, 2024
@NikaHsn @Jordan-Nelson
fix(core): improve amplify configure api error message (#5021)
7f6ae55
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version
5dbac2a 
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version
6dbd3be 
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Jordan-Nelson Jordan-Nelson mentioned this pull request Jun 27, 2024
Merged
Jordan-Nelson added a commit that referenced this pull request Jun 27, 2024
@Jordan-Nelson
chore(version): Bump version (#5092)
0ec1760 
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079))
- fix(core): improve amplify configure api error message ([#5021](#5021))
- fix(notifications): allow offline configuration
- fix: wait for in progress multi part uploads to cancel for `pause` and `cancel`

- feat: Support Amplify Gen 2 outputs ([#5073](#5073))

Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Equartey Equartey Equartey approved these changes

@khatruong2009 khatruong2009 khatruong2009 approved these changes

@tyllark tyllark tyllark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NikaHsn @Equartey @khatruong2009 @tyllark