Amplify analytics #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjnoyp
requested review from
Amplifiyer,
Ashish-Nanda,
haverchuck and
mlabieniec
haverchuck
approved these changes
Aug 4, 2020
- Remove excess lines - Remove excess comments - Update Podspec - Delete unnecessary Podfile~ - Fix TAG / MethodChannel on Kotlin - Switch to Future<VOID> instead of Future<BOOL> - Call all Analytics Plugins attached in AnalyticsCategories - Rename Constructor->Bridge Licenses for All Files Update Analytics Example App Remove unneeded imports Use Auth plugin instead of manually importing native auth Apply dart formatting to Kotlin and Dart files Fix Analytics Method Signature Switch to void Update Dart unit tests
fjnoyp
force-pushed
the
amplify_analytics
branch
from
c53c2de
to
4aeefa2
Compare
13 tasks
fjnoyp
referenced
this pull request
in fjnoyp/amplify-flutter
Aug 29, 2023
fjnoyp
referenced
this pull request
in fjnoyp/amplify-flutter
Sep 5, 2023
Update Log Metric TEMP Ensure PR Trigger try fix fix formatting issues fix error 3 fix ending ) Pass github token fix syntax error remove smart quote BS Ensure Run temp update 2 temp Hopefully this fixes it Let’s try again Fix Attempt #4 fix failing step pipe fix improper job status fix dart script namings #7 fix freaking typo #8 fix mappings again #9 Print for Debug #10 Remove Quotes? aws-amplify#11 fixi failing trigger debug - print dart outputs fix syntax error try to get output force github actions to run fix syntax stop integ tests trynig to get output
14 tasks
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of original amplify_analytics pull request with additional changes as suggested by Praveen.
Here are some ongoing discussion from before:
Remove addPlugin for Cognito in Kotlin and Swift
We need to confirm if we want to support pre-Flutter-1.12 Android projects officially.
Discuss with team about an automatic code style/spacing enforcer
https://dart.dev/guides/language/effective-dart/style
dartfmt