Skip to content

Commit

Permalink
chore: adding in thrown errors on certain cloudwatch operations
Browse files Browse the repository at this point in the history
  • Loading branch information
Eddie Keller committed May 26, 2021
1 parent 872e029 commit 7da18bf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
Expand Up @@ -76,7 +76,7 @@ describe('AWSCloudWatchProvider', () => {
});
};

await expect(action()).rejects.toThrowError();
expect(action()).rejects.toThrowError();
spyon.mockRestore();
});
});
Expand Down
11 changes: 10 additions & 1 deletion packages/core/src/Providers/AWSCloudWatchProvider.ts
Expand Up @@ -125,6 +125,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return output;
} catch (error) {
logger.error(`error creating log group - ${error}`);
throw error;
}
}

Expand All @@ -147,6 +148,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return output;
} catch (error) {
logger.error(`error getting log group - ${error}`);
throw error;
}
}

Expand All @@ -171,6 +173,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return output;
} catch (error) {
logger.error(`error creating log stream - ${error}`);
throw error;
}
}

Expand All @@ -192,6 +195,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return output;
} catch (error) {
logger.error(`error getting log stream - ${error}`);
throw error;
}
}

Expand All @@ -213,6 +217,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return output;
} catch (error) {
logger.error(`error getting log events - ${error}`);
throw error;
}
}

Expand Down Expand Up @@ -260,6 +265,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
} catch (err) {
const errString = `failure during log group search: ${err}`;
logger.error(errString);
throw err;
}
}

Expand Down Expand Up @@ -303,6 +309,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
} catch (err) {
const errString = `failure during log stream search: ${err}`;
logger.error(errString);
throw err;
}
}

Expand Down Expand Up @@ -384,6 +391,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
return this._nextSequenceToken;
} catch (err) {
logger.error(`failure while getting next sequence token: ${err}`);
throw err;
}
}

Expand Down Expand Up @@ -429,6 +437,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
});
} else {
this._dataTracker.eventUploadInProgress = false;
throw err;
}
}
}
Expand Down Expand Up @@ -493,7 +502,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
);
this._dataTracker.eventUploadInProgress = false;

throw Error;
throw err;
}
}

Expand Down

0 comments on commit 7da18bf

Please sign in to comment.