Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 4 / Angular 7 - aws amplify doesn't have Federated Sign in / Sign up #2455

Closed
bijanmmarkes opened this issue Jan 3, 2019 · 16 comments
Closed
Assignees
Labels
Angular Related to Angular 2+ Auth Related to Auth components/category feature-request Request a new feature Ionic Related to Ionic Framework UI Related to UI Components

Comments

@bijanmmarkes
Copy link

bijanmmarkes commented Jan 3, 2019

**Is your feature request related to a problem?

AWS Amplify for Ionic 4 doesn't seem to have any way to complete federated logins using amazon, google, or facebook. I have seen documentation for React Native but none for Ionic 4, How would I enable federated sign in / sign up via social logins through the <amplify-authenticator> ?

Describe the solution you'd like
I would like the ability to enable federated sign up / sign in / sign out while still being able to use the provided module / theme. I have seen React Native able to add a parameter to <amplify-authenticator> such as federated = {federated}, Why is this type of functionality not available for Ionic 4?

Describe alternatives you've considered
Most preferably it would be great to have the Sign up / Sign in UI come with a toggle feature for social providers, and some documentation to go with it. It seems AWS Amplify is lacking for Ionic 4 and prioritizes React, it would be nice to see some of the features React has come to Ionic 4.

Additional context
No way to enable federated sign in using the UI or other methods on Ionic 4 - AWS Amplify latest version.

@bijanmmarkes bijanmmarkes changed the title Ionic 4 - aws amplify doesn't have Federated Sign in / Sign up Ionic 4 / Angular 7 - aws amplify doesn't have Federated Sign in / Sign up Jan 3, 2019
@jordanranz jordanranz added Auth Related to Auth components/category Angular Related to Angular 2+ Ionic Related to Ionic Framework labels Jan 3, 2019
@bijanmmarkes
Copy link
Author

@haverchuck Any news on this?

@elorzafe elorzafe added investigating This issue is being investigated and removed investigating This issue is being investigated labels Mar 1, 2019
@martin-slater
Copy link

Is there any plans for this in the roadmap? It is disappointing that it is not supported yet for ionic 4 when react has it all

@MurlidharVarma
Copy link

any update on this?

@LiorSaadon
Copy link

any news for federated login ?

on "aws-amplify-angular": "3.0.3" i found this part in the code that might indicate federated sign in is coming, but will it support SAML ADFS?

var federatedSignIn = {
section: 'federated-sign-in-section',
bodySection: 'federated-sign-in-body-section',
signInButtons: 'federated-sign-in-buttons',
};

@jordanranz jordanranz removed the investigating This issue is being investigated label Jul 2, 2019
@jordanranz
Copy link
Contributor

This is in progess: #2900

@LiorSaadon
Copy link

This is in progess: #2900

i went through the changes in the pull request, he did great job for facebook,google,amazon sign in but still no SAML ADFS :(

@oliverandersencox
Copy link

are we looking any closer on this one? Really keen to get facebook login into the app

@stale
Copy link

stale bot commented Aug 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@oliverandersencox
Copy link

no don't close this, we are waiting to here about this feature

@oliverandersencox
Copy link

@haverchuck any progress on this. We're waiting on this to release out app

@giacomocarrozzo
Copy link

Any update on this?

@oliverandersencox
Copy link

any of the aws team care to give us any sort of feedback on this?

@jordanranz
Copy link
Contributor

jordanranz commented Oct 28, 2019

Quick update on this. We will be implementing Federated Sign In buttons into our UI Component refactor: #3279

In the meantime, I'll check the status for #2900

@sammartinez sammartinez added feature-request Request a new feature and removed needs-review labels Oct 30, 2019
@sammartinez
Copy link
Contributor

Resolving this feature request as completed this in UI Components

@oliverandersencox
Copy link

for angular? if so where are the docs, as the app store REJECTS any redirection to sfari to authenticate

@sammartinez sammartinez reopened this Feb 25, 2021
@abdallahshaban557 abdallahshaban557 added the UI Related to UI Components label Jun 20, 2022
@cwomack cwomack self-assigned this May 5, 2023
@cwomack
Copy link
Contributor

cwomack commented May 5, 2023

For anyone following this issue, Federated Sign In & Sign up is now supported with Angular and React when using the Authenticator connected component.

If anyone continues to experience problems with the Authenticator as described in this issue, please feel free to reply back or open a new issue within the amplify-ui repository (where the Authenticator features/issues are now managed).

@cwomack cwomack closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular Related to Angular 2+ Auth Related to Auth components/category feature-request Request a new feature Ionic Related to Ionic Framework UI Related to UI Components
Projects
None yet
Development

No branches or pull requests