-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-amplify-angular/auth): Add federated sign in for social providers #2900
feat(aws-amplify-angular/auth): Add federated sign in for social providers #2900
Conversation
…amplify-js into angularFederatedIdentity
@OrozcoJonathan Can you look into resolving the conflicts please? |
Hey @OrozcoJonathan, I've resolved the conflicts and got the tests to pass. Will be further testing and reviewing this today. |
This pull request introduces 6 alerts when merging 5c431d1 into ce7ca96 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 175 175
Lines 9672 9672
Branches 1982 1982
=======================================
Hits 7388 7388
Misses 2137 2137
Partials 147 147 Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging a2a4c34 into ce7ca96 - view on LGTM.com new alerts:
|
@OrozcoJonathan thanks for this PR, we pull this changes forward into new UI components libraries. For more information on how to use federated sign in with social providers you can find it here |
@elorzafe it states federated login by Identity Pools (IDP) does this mean it won’t work with User Pools Federated Logins? |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#2456
#1488
#3537
Description of changes:
This change adds a federated sign in component to the aws-amplify-angular library
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.