Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-amplify-angular/auth): Add federated sign in for social providers #2900

Conversation

OrozcoJonathan
Copy link
Contributor

@OrozcoJonathan OrozcoJonathan commented Mar 19, 2019

Issue #, if available:
#2456
#1488
#3537

Description of changes:
This change adds a federated sign in component to the aws-amplify-angular library

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haverchuck haverchuck added the needs-discussion Used for internal discussions label Apr 17, 2019
@haverchuck haverchuck changed the base branch from master to beta July 15, 2019 15:15
@haverchuck haverchuck changed the base branch from beta to master July 15, 2019 15:15
@sammartinez
Copy link
Contributor

@OrozcoJonathan Can you look into resolving the conflicts please?

@sammartinez sammartinez added Analytics Related to analytics needs-review and removed needs-discussion Used for internal discussions Analytics Related to analytics labels Oct 30, 2019
@iartemiev
Copy link
Contributor

Hey @OrozcoJonathan, I've resolved the conflicts and got the tests to pass. Will be further testing and reviewing this today.

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 6 alerts when merging 5c431d1 into ce7ca96 - view on LGTM.com

new alerts:

  • 3 for Useless assignment to local variable
  • 3 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2900   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files         175      175           
  Lines        9672     9672           
  Branches     1982     1982           
=======================================
  Hits         7388     7388           
  Misses       2137     2137           
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c337b7...256762a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 1 alert when merging a2a4c34 into ce7ca96 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@elorzafe
Copy link
Contributor

@OrozcoJonathan thanks for this PR, we pull this changes forward into new UI components libraries. For more information on how to use federated sign in with social providers you can find it here

@elorzafe elorzafe closed this Apr 23, 2020
@tvb
Copy link

tvb commented Apr 26, 2020

@elorzafe it states federated login by Identity Pools (IDP) does this mean it won’t work with User Pools Federated Logins?

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants