Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to apply the patch #4231

Closed
ashish-dirkmedia-de opened this issue Oct 22, 2019 · 4 comments
Closed

How to apply the patch #4231

ashish-dirkmedia-de opened this issue Oct 22, 2019 · 4 comments
Labels
Angular Related to Angular 2+ question General question to-be-reproduced Used in order for Amplify to reproduce said issue

Comments

@ashish-dirkmedia-de
Copy link

I am using angular 6 with auth
I found many usefull patch. But dont know how to apply these patch.
i.e update in node_modules aws-amplify-angular folder or copy src folder of aws-amplify-angular as a new modules (which I tried without success).
If have to update in aws-amplify-angular folder which files should I update.
Please can someone help me on this

@ashish-dirkmedia-de ashish-dirkmedia-de added the question General question label Oct 22, 2019
@Amplifiyer Amplifiyer added Angular Related to Angular 2+ to-be-reproduced Used in order for Amplify to reproduce said issue labels Oct 22, 2019
@Amplifiyer
Copy link
Contributor

Hi @ashish-dirkmedia-de, can you provide more context on what you are trying to achieve? I don't fully understand what you meant by patches here. Please share some code samples with detailed explanations.

Not sure if it'll be of any help, but here is the local development guide for developing the aws-amplify library https://github.com/aws-amplify/amplify-js/wiki/Local-Development

@ashish-dirkmedia-de
Copy link
Author

Like issue "Add federated sign in for social providers"
It says to add components "src/components/authenticator/federated-sign-in-component/federated-sign-in.class.ts", "src/components/authenticator/federated-sign-in-component/federated-sign-in.component.core.ts"
etc.
Should I actually change in packages/aws-amplify-angular?

@Amplifiyer
Copy link
Contributor

Hi @ashish-dirkmedia-de, I'm assuming you are talking about #2900 which is a PR for adding federated providers in angular components. And I believe #4082 is also duplicate of this.

If you meant to pull these PR changes (which I believe you are calling patches), you can pull the fork and branch of the PR, in this case OrozcoJonathan:angularFederatedIdentity and merge in your local fork. Please note that

  • The PR is not approved, so the changes are not yet tested and not recommended for production use case
  • The PR is a little old, and so there will be a bunch of conflicts while merging with your local up to date fork.

For further communication, please reply directly on the PR, or +1 if you would want to get it merged to master. Closing this issue.

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Angular Related to Angular 2+ question General question to-be-reproduced Used in order for Amplify to reproduce said issue
Projects
None yet
Development

No branches or pull requests

2 participants