Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-amplify): delete unused AmazonAIPredictionsProvider import #4629

Merged
merged 1 commit into from
Dec 27, 2019
Merged

fix(aws-amplify): delete unused AmazonAIPredictionsProvider import #4629

merged 1 commit into from
Dec 27, 2019

Conversation

AryanJ-NYC
Copy link
Contributor

Description of changes:
AmazonAIPredictionsProvider is unused in packages/aws-amplify/src/index.ts. It is likely to have been meant to be exported.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2019

This pull request fixes 1 alert when merging bc2c2aa into bc8ae26 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #4629 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4629   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         174      174           
  Lines        9619     9619           
  Branches     1904     1962   +58     
=======================================
  Hits         7334     7334           
+ Misses       2148     2140    -8     
- Partials      137      145    +8
Impacted Files Coverage Δ
packages/core/src/OAuthHelper/GoogleOAuth.ts 31.25% <0%> (ø) ⬆️
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0%> (ø) ⬆️
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts 18.64% <0%> (ø) ⬆️
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 61.23% <0%> (ø) ⬆️
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0%> (ø) ⬆️
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.09% <0%> (ø) ⬆️
packages/auth/src/OAuth/OAuth.ts 48.48% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3ab44...0ddc0a5. Read the comment docs.

@jordanranz
Copy link
Contributor

It seems to have been removed in this commit for some reason:
0ca069b#diff-5d7160e65fbe3b5c20d17db97273f2b8

I'll see if there is a problem re-adding it. Thanks for contributing @AryanJ-NYC

@jordanranz
Copy link
Contributor

jordanranz commented Dec 27, 2019

@AryanJ-NYC, we would like to start moving away from exporting everything from aws-amplify due to bundle size concerns. This was the reasoning for removing it as an export. That being said we want to encourage the use of this provider module via modular export like in these docs.

If you could remove both the export and the import at the top, we can merge this PR.

@lgtm-com
Copy link

lgtm-com bot commented Dec 27, 2019

This pull request fixes 1 alert when merging bb282c7 into 52bd287 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 27, 2019

This pull request fixes 1 alert when merging 0ddc0a5 into eb3ab44 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@AryanJ-NYC AryanJ-NYC changed the title fix(aws-amplify): export AmazonAIPredictionsProvider fix(aws-amplify): delete unused AmazonAIPredictionsProvider import Dec 27, 2019
@AryanJ-NYC
Copy link
Contributor Author

@jordanranz done. Sorry if this small PR took any of your time!

@jordanranz
Copy link
Contributor

No problem at all! Thanks for taking the time to contribute :D

Copy link
Contributor

@jordanranz jordanranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanranz jordanranz merged commit 8781ce4 into aws-amplify:master Dec 27, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants