Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore show performance issues on Safari. #5434

Closed
rpostulart opened this issue Apr 16, 2020 · 7 comments · Fixed by #5942
Closed

Datastore show performance issues on Safari. #5434

rpostulart opened this issue Apr 16, 2020 · 7 comments · Fixed by #5942
Assignees
Labels
DataStore Related to DataStore category feature-request Request a new feature

Comments

@rpostulart
Copy link

rpostulart commented Apr 16, 2020

When there are for example 600 records in your DB and you init/start your app with

DataStore.configure(awsConfig)

DataStore.observe(Quiz).subscribe(Quiz => {
console.log(Quiz)
})

The first time all the records are loaded. In seems like in chrome it's working well and in Safari there is some idle time and looks like your application crashes, your app continues working after all the records are loaded.

@rpostulart rpostulart added the to-be-reproduced Used in order for Amplify to reproduce said issue label Apr 16, 2020
@jordanranz jordanranz added the DataStore Related to DataStore category label Apr 16, 2020
@rpostulart
Copy link
Author

Anyone?

@manueliglesias
Copy link
Contributor

Hi @rpostulart

I am working on some performance improvements on the DataStore, if we don't encounter issues or problems, we are targeting next to release them.

I just tested a DataStore app with an API returning 100k items and it worked fine on Safari, so hopefully these fixes will make the issue go away for you.

Thank you for the patience

@manueliglesias manueliglesias added feature-request Request a new feature and removed to-be-reproduced Used in order for Amplify to reproduce said issue labels May 19, 2020
@rpostulart
Copy link
Author

Hi good to hear, but were you also able to reproduce the issue / did you noticed the performance issue?

@manueliglesias
Copy link
Contributor

Hey @rpostulart

We just published new versions to the unstable npm tag with a bunch of improvements, it would be great if you can take a look and try them

@rpostulart
Copy link
Author

Will try immediately, thanks team great job. I will provide you the feedback soon

@rpostulart
Copy link
Author

I added some error details at the merge page, is that ok?

@manueliglesias manueliglesias self-assigned this Jun 1, 2020
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DataStore Related to DataStore category feature-request Request a new feature
Projects
None yet
3 participants