-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make withAuthenticator
HOC configurable
#110
Make withAuthenticator
HOC configurable
#110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 53 53
Lines 2517 2517
Branches 510 510
=======================================
Hits 2285 2285
Misses 221 221
Partials 11 11
Continue to review full report at Codecov.
|
0556e19
to
8bfa094
Compare
8bfa094
to
042f0a3
Compare
@rlmartin the structure has changed a bit here, the core logic has moved into aws-amplify, can you have a look and see if you can merge these into the latest. Thanks. |
@mlabieniec sure I'll take a look. |
042f0a3
to
ed18cb8
Compare
@mlabieniec in case you missed it, I updated this PR. |
@rlmartin could you provide us an example to show how does it work with the code? I am trying to pass a customized component into the array and expecting to just get that component rendered like:
and using it in the hoc like:
But turns out to be an error saying: Thanks. Also really appreciate it if you could add it into the readme. |
Hi @powerful23 - I believe that's an error from React Native. You need to pass in an instance of the class, not the class itself (i.e. I'll update the README :) |
342c124
to
f399d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great job!
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This will allow for building custom SignIn, Loading, etc components but still leveraging the ease of
withAuthenticator
.