fix(storage): make getProperties param optional #11413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanabrooks
reviewed
May 26, 2023
| throw new Error( | ||
| `.getProperties is not implemented on provider ${plugin.getProviderName()}` | ||
| ) | ||
| } |
There was a problem hiding this comment.
What would a test look like for this? We should probably include one here.
israx
changed the title
jimblanc
approved these changes
May 26, 2023
haverchuck
approved these changes
May 26, 2023
erinleigh90
added a commit
that referenced
this pull request
May 26, 2023
* chore(release): Publish [ci skip] - aws-amplify@5.2.3 - @aws-amplify/datastore-storage-adapter@2.0.33 - @aws-amplify/datastore@4.4.0 - @aws-amplify/predictions@5.2.0 - @aws-amplify/storage@5.3.0 * chore(release): update API docs [ci skip] * fix(notifications): Add babel plugins to devDependencies (#11414) * fix(storage): make getProperties param optional (#11413) * Revert "fix(storage): make getProperties param optional (#11413)" This reverts commit 5d00b1f. * Revert "feat(storage): getProperties API (#11378)" This reverts commit 3bed12b. --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com> Co-authored-by: Jim Blanchard <jablanch@amazon.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
erinleigh90
added a commit
that referenced
this pull request
May 29, 2023
* chore(release): Publish [ci skip] - aws-amplify@5.2.3 - @aws-amplify/datastore-storage-adapter@2.0.33 - @aws-amplify/datastore@4.4.0 - @aws-amplify/predictions@5.2.0 - @aws-amplify/storage@5.3.0 * chore(release): update API docs [ci skip] * fix(notifications): Add babel plugins to devDependencies (#11414) * fix(storage): make getProperties param optional (#11413) * Revert "fix(storage): make getProperties param optional (#11413)" This reverts commit 5d00b1f. * Revert "feat(storage): getProperties API (#11378)" This reverts commit 3bed12b. * fix(core): bundle react-native-url-polyfill to unblock jest test failure (#11422) * fix(core): bundle react-native-url-polyfill to unblock jest test failure * Revert "test(notification): unblock unit test failure of rn url polyfill" This reverts commit dbacebc. * chore: remove unused code * chore: remove unused polyfills/URL/package.json * chore(release): Publish [ci skip] - @aws-amplify/analytics@6.1.1 - @aws-amplify/api-graphql@3.2.1 - @aws-amplify/api-rest@3.1.1 - @aws-amplify/api@5.1.1 - @aws-amplify/auth@5.3.7 - aws-amplify@5.2.4 - @aws-amplify/cache@5.0.33 - @aws-amplify/core@5.3.1 - @aws-amplify/datastore-storage-adapter@2.0.34 - @aws-amplify/datastore@4.4.1 - @aws-amplify/geo@2.0.33 - @aws-amplify/interactions@5.0.33 - @aws-amplify/notifications@1.1.7 - @aws-amplify/predictions@5.2.1 - @aws-amplify/pubsub@5.1.16 - @aws-amplify/pushnotification@5.0.33 - @aws-amplify/storage@5.3.1 * chore(release): update API docs [ci skip] --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com> Co-authored-by: Jim Blanchard <jablanch@amazon.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com> Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Release 5.2.3 brought a braking change by introducing a getProperties required field in the StorageProvider interface. The solution was to make this field optional
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.