Feat/user agent enhancements/auth oauth #11459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e based on changes
…ain' into feat/user-agent-enhancements/auth
…-enhancements/auth-federated
…ain' into feat/user-agent-enhancements/auth-oauth
elorzafe
approved these changes
Jun 5, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## feat/user-agent-enhancements/main #11459 +/- ##
==================================================================
Coverage 83.15% 83.15%
==================================================================
Files 260 260
Lines 20437 20438 +1
Branches 4402 4402
==================================================================
+ Hits 16995 16996 +1
Misses 3156 3156
Partials 286 286
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erinleigh90
merged commit 0b053b3
into
aws-amplify:feat/user-agent-enhancements/main
5 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds custom user agent details header to OAuth call to
/oauth2/tokenendpoint with category, action, and framework.Description of how you validated changes
Validated using a sample app with linked packages and checking that
x-amz-user-agentheader was sent with the expected string:aws-amplify/5.2.4 auth/25 framework/0Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.