fix: React detection and Analytics batch upload #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocaaro
commented
Jun 9, 2023
| @@ -46,7 +46,7 @@ const trackers = { | |||
| }; | |||
|
|
|||
| type TrackerTypes = keyof typeof trackers; | |||
| type Trackers = typeof trackers[TrackerTypes]; | |||
| type Trackers = (typeof trackers)[TrackerTypes]; | |||
There was a problem hiding this comment.
Had made a change to this file I rolled back, but prettier is really insistent that this line be changed... 🙄
erinleigh90
approved these changes
Jun 9, 2023
cshfang
reviewed
Jun 9, 2023
| { | ||
| credentials, | ||
| region, | ||
| userAgentValue: getAnalyticsUserAgentString(AnalyticsAction.Record), |
There was a problem hiding this comment.
Is this meant to track how often Record is called on Analytics or how often events are batch sent to Pinpoint?
Comment on lines
+9
to
+15
| const elementKeyPrefixedWithReact = k => { | ||
| return k.startsWith('_react') || k.startsWith('__react'); | ||
| }; | ||
| const elementIsReactEnabled = e => { | ||
| return Object.keys(e).find(elementKeyPrefixedWithReact); | ||
| }; | ||
| const allElementsWithId = () => Array.from(document.querySelectorAll('[id]')); |
There was a problem hiding this comment.
Nit since this doesn't run often to my understanding but typically we'd want to extract these so they're not recreated every time reactWebDetect() is run.
Second nit would be to use more meaningful parameter names... it's easy enough to intuit that k is key or e is element but it's even easier when it's spelled out for you.
stocaaro
merged commit f2b1740
into
aws-amplify:feat/user-agent-enhancements/main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
React 18 makes complicated most types of detection. Using a common root element lookup wasn't working consistently. This adds a more robust search mechanism that works on the 3 react 18 apps I've tested.
Also, Analytics batch events where missing the user agent action, which this fixes.
Description of how you validated changes
Tested snippets manually, then by linking changes into a test app.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.