-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release(required): Amplify JS release #11744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add canary testing --------- Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com>
Update on-schedule-canary-test.yml
Co-authored-by: Sridhar <ashwsrir@amazon.com>
* chore: port code from CognitoUser and CognitoUserPool to internals * chore: delete InternalCognitoUserPool - separate PR * chore: update imports and class name * feat: add userAgentValue param to cognito client api's * feat: add userAgentValue param to InternalCognitoUser api's, pass to client * feat: make CognitoUser extend InternalCognitoUser and override api's * test: update tests to work with additional param, minor fix * chore: clean up unused imports and const's * feat: add missing userAgentValue param * chore: add new param to documentation comments * build: export InternalCognitoUser from internals scope * fix: remove default from InternalCognitoUser to fix scoped export * fix: fix typo causing signOut failure * build: correct index.d.ts files with changes * test: revert auth tests * chore: increase bundle size limits * chore: simplify InternalCognitoUser import --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com>
* chore: run canary everyday at 9am * chore: code cleanup Co-authored-by: Venkata Ramyasri Kota <34170013+kvramyasri7@users.noreply.github.com> * chore: update canary cron to 9amPDT * chore: code cleanup --------- Co-authored-by: Sridhar <ashwsrir@amazon.com> Co-authored-by: Venkata Ramyasri Kota <34170013+kvramyasri7@users.noreply.github.com>
* chore: copy Auth code to InternalAuth * feat: add customUserAgentDetails param to InternalAuth methods * feat: make AuthClass extend InternalAuthClass, override functions with extra param * build: export auth internals from /internals scope * fix: changes signUp back to method type instead of prop so Auth can extend the method * chore: update auth lint settings to allow class arrow functions to end in semi-colon * fix: add overloaded method signature back in - unrelated change * test: fix auth tests by mocking InternalAuthClass instead of AuthClass * chore: change arrow methods to normal functions * fix: remove async from overridden async functions * chore: increase bundle size limits * fix: remove internalSignUp and fix rest attr with overload and any * fix: remove internalSignUp and fix rest attr with overload and any * chore: update jsdocs * chore: increase bundle size limits
* chore: port CognitoUserPool over to InternalCognitoUserPool * chore: restore CognitoUserPool * feat: add userAgentValue parameter to signUp * feat: update class name and imports * feat: make CognitoUserPool extend internal and override signUp * feat: export InternalCognitoUserPool from internals index * feat: send userAgentValue to client service call * test: fix internalsIndex test * build: export InternalCognitoUserPool from internals scope * chore: update CognitoUserPool type to extend internal * Apply suggestions from code review Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com> * chore: remove unnecessary test on internals index * chore: increase bundle size limit --------- Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com> Co-authored-by: israx <70438514+israx@users.noreply.github.com>
Co-authored-by: Sridhar <ashwsrir@amazon.com>
Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.9 to 0.23.10. - [Release notes](https://github.com/gjtorikian/commonmarker/releases) - [Changelog](https://github.com/gjtorikian/commonmarker/blob/v0.23.10/CHANGELOG.md) - [Commits](gjtorikian/commonmarker@v0.23.9...v0.23.10) --- updated-dependencies: - dependency-name: commonmarker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
HuiSF
approved these changes
Aug 9, 2023
erinleigh90
approved these changes
Aug 9, 2023
jimblanc
approved these changes
Aug 9, 2023
Reactive native tests on CCI are failing because CCI has deprecated support for xcode 13.2.1. |
svidgen
approved these changes
Aug 10, 2023
Comment on lines
+1
to
+10
on: | ||
# Tests scheduled at 4pm(UTC) / 9am(PDT) everyday | ||
# default supported timezone is UTC | ||
schedule: | ||
- cron: '0 16 * * *' | ||
|
||
jobs: | ||
canaries: | ||
secrets: inherit | ||
uses: ./.github/workflows/callable-canary-e2e.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.