Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade isomorphic-unfetch dependency to ^4.0.0 #11762

Closed
wants to merge 4 commits into from

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Aug 9, 2023

Also remove the runtime dependency of @types/node-fetch because the new isomorphic-unfetch fixed the missing types and do not introduce the @types/node dependency. This addresses #11736

This change also upgrades transitive dependency of node-fetch to 3.3.2. Confirmed no breaking API changes or platform support change.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Also remove the runtime dependency of @types/node-fetch because
the new isomorphic-unfetch fixed the missing types and do not
introduce the @types/node dependency. This fixes aws-amplify#11736
@AllanZhengYP AllanZhengYP requested review from a team as code owners August 9, 2023 16:42
@AllanZhengYP AllanZhengYP marked this pull request as draft August 9, 2023 16:46
@AllanZhengYP
Copy link
Contributor Author

The build failed: https://github.com/aws-amplify/amplify-js/actions/runs/5811778967/job/15755750335?pr=11762. It looks like bumping up the node-fetch dependency will indeed break the customers. For some reason, new node-fetch starts to be included in the browser build artifact.

@codecov-commenter
Copy link

Codecov Report

Merging #11762 (017f3f0) into main (57127c5) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main   #11762   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files         348      348           
  Lines       21037    21037           
  Branches     4445     4445           
=======================================
  Hits        17678    17678           
  Misses       3098     3098           
  Partials      261      261           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bogdanailincaipnt
Copy link

Hello, I appreciate the work. I think "tslib", "react-native-url-polyfill" should also be moved to devDependencies.

@AllanZhengYP
Copy link
Contributor Author

Hello, I appreciate the work. I think "tslib", "react-native-url-polyfill" should also be moved to devDependencies.

Hi @bogdanailincaipnt The tslib should always be a runtime dependency because it's required by TS generated code at runtime. We added "react-native-url-polyfill" for backward compatibility, we have decided the remove it in next major version. If you want to know more about our next major improvement, you can refer to the pinned issue: #11113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants