fix(core): fail to clean up framework observers #11782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocaaro
dismissed
erinleigh90’s stale review
The merge-base changed after approval.
erinleigh90
previously approved these changes
Aug 10, 2023
jimblanc
previously approved these changes
Aug 10, 2023
HuiSF
dismissed stale reviews from erinleigh90, cwomack, and jimblanc
via
f4dc3bf
HuiSF
force-pushed
the
hui/fix/core/framework-observers-memory-leak
branch
from
6043df7
to
f4dc3bf
Compare
jimblanc
previously approved these changes
Aug 11, 2023
erinleigh90
previously approved these changes
Aug 11, 2023
david-mcafee
requested changes
Aug 11, 2023
HuiSF
force-pushed
the
hui/fix/core/framework-observers-memory-leak
branch
from
f4dc3bf
to
11c5509
Compare
| }); | ||
|
|
||
| afterAll(() => { | ||
| jest.useRealTimers(); |
There was a problem hiding this comment.
nit: I'd prefer using afterEach (see previous suggestion) for better isolation between tests, but not a blocker.
david-mcafee
approved these changes
Aug 11, 2023
jimblanc
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added logic to clean up the Framework detection observers, and ignore new incoming observers after the detection completes.
Issue #, if available
#11770
Description of how you validated changes
Unit tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.