feat(data): add custom primary key and related model tests #11836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11836 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 341 341
Lines 21579 21579
Branches 4611 4611
=======================================
Hits 18051 18051
Misses 3241 3241
Partials 287 287 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
david-mcafee
force-pushed
the
cpk-related-models
branch
from
b9ff204
to
7dea448
Compare
david-mcafee
commented
Aug 18, 2023
| @@ -9,6 +9,8 @@ on: | |||
| push: | |||
| branches: | |||
| - feat/example-integ-test-branch/main | |||
| # TODO: remove before merging PR - added for test run prior to merge | |||
| - cpk-related-models | |||
There was a problem hiding this comment.
4 tasks
svidgen
approved these changes
Aug 23, 2023
erinleigh90
approved these changes
Aug 24, 2023
jimblanc
approved these changes
Aug 24, 2023
stocaaro
approved these changes
Aug 24, 2023
david-mcafee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Successful test run of new E2E tests
DataStore custom primary key E2E tests were recently disabled due to test flakiness after migrating to GitHub Actions. Our existing related model tests have sufficient overlap with CPK tests, so we were able to perform the update without significant loss of test coverage.
This PR adds test configuration to use the new custom primary key + related models sample app. The new sample app is a fork of the existing related model app, with the inclusion of the following missing test cases:
Once this PR has been merged I will remove existing sample apps + tests for both custom primary keys and related models.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.